Alibaba: add Alibaba Cloud manual mode#411
Alibaba: add Alibaba Cloud manual mode#411dongchen126 wants to merge 1 commit intoopenshift:masterfrom
Conversation
Support the Alibaba Cloud platform in manual mode Add AlibabaCloudProviderSpec and AlibabaCloudProviderStatus Signed-off-by: sunhui <[email protected]>
|
Hi @dongchen126. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dongchen126 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| // ConditionKeyValue - mapping of values for the chosen type | ||
| // +k8s:deepcopy-gen=false | ||
| type ConditionKeyValue map[string]interface{} |
There was a problem hiding this comment.
Using type interface{} complicates generating deep-copy functions. See https://github.com/openshift/cloud-credential-operator/blob/master/pkg/apis/cloudcredential/v1/aws_manual.deepcopy.go and openshift/api#683 (review) .
Just because we made this mistake for the AWS cloud, does not mean we should repeat it for Alibaba Cloud. Please specify the exact values this field can hold, or just remove the ability to specify conditions as part of each Entry.
If we do in fact expect to have components specify static Conditions as part of their permissions lists, I'd like to see some examples.
There was a problem hiding this comment.
Thanks for your review.
At present, Condition is not needed in Alibaba Cloud's credsRequest, so I removed it.
|
Closed this PR due to will use new PR #412 |
3 participants
Support the Alibaba Cloud platform in manual mode
phase 1: Add 'AlibabaCloudProviderSpec' and 'AlibabaCloudProviderStatus'
phase 2: 'ccoctl' support（ongoing)